Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add impl type to BeelineOpts #389

Merged
merged 2 commits into from
Jul 7, 2021
Merged

Add impl type to BeelineOpts #389

merged 2 commits into from
Jul 7, 2021

Conversation

Cameron485
Copy link
Contributor

No description provided.

@Cameron485 Cameron485 requested a review from a team July 2, 2021 09:21
GMasucci-Twig
GMasucci-Twig approved these changes Jul 5, 2021
View reviewed changes
Copy link

@GMasucci-Twig GMasucci-Twig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrects missing impl

vreynolds
vreynolds approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@vreynolds vreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@vreynolds vreynolds merged commit ca4b9b2 into honeycombio:main Jul 7, 2021
@vreynolds vreynolds added the version: bump patch A PR with release-worthy changes and is backwards-compatible. label Jul 7, 2021
@Cameron485 Cameron485 deleted the add-impl-type branch July 8, 2021 08:25
@robbkidd robbkidd mentioned this pull request Jul 8, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vreynolds vreynolds vreynolds approved these changes

@GMasucci-Twig GMasucci-Twig GMasucci-Twig approved these changes

Assignees
No one assigned
Labels
version: bump patch A PR with release-worthy changes and is backwards-compatible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cameron485 @vreynolds @GMasucci-Twig